While changes look OK in general, please use the defines from "tos.h"
instead of magic numbers in Keymap_SetCountry()!
I'll add that to the PR branch.
But "perfect is enemy of good", and this clearly improves what Hatari
had earlier...
The reason I started doing it was because of the argument about the minus key mapping. It was unfeasible to try and maintain one symbolic map when it cannot be agreed what TOS it was even aiming for.
At least when each is broken into pairs with host and TOS intending the same language, there is a lot less controversy.
I think almost all of the mappings I have chose should be uncontroversial, however I noted 3 keys in FR and 1 in SE
I would suggest having comment updates/additions as separate commit, and
larger code changes split per language (updates for just couple of lines
could maybe go to same commit).
There are no logical code changes in my PR. All changes are to individual case statements to correct things Thomas missed or altered when translating mine.
Per-language code changes are already grouped by language, as each language was its own function. I am not sure what benefit it would have to put them in separate commits? I'm willing to do that if it's necessary, but they're already grouped by language as-is.
-- Brad Smith