| Re: [hatari-devel] Recent symbolic keyboard mapping change |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Recent symbolic keyboard mapping change
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Fri, 4 Oct 2024 16:33:51 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1728059633; bh=3XjxaKdGLfaBZLh8vsZg9qTNnZ6MA5gti0c+8yROKis=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=ohKGWLszXE4J0efm8/GS73QZ2nlhAhhcsrVNOZeiqsF5dR3xkzPuYNyUHlF1tuTRM wrrG9ybVM2lQpqocaSeT6KKCBcDufJdRweOkwHjKrjjYOmw1z5awumndk9J/F0Dovd +nvdEly3w87RnIKZaXssoniWcZEw/fXZh225R0BefnLOM1GufyMWjZrtQr2jHRMDzn 4JJXCBEOGby6wNkbhFPy/ceu/Q59iNC4SFctrMupR7ZczpfVNdjo+v5Jl0LYeFh48x Dgu0t1xTo5Ds7J87RhzvL+065/Xs/qW7mqSvsUsfkKuLNbkZkEa0DyIq69ZVVaXFCO hNkKyWtG0TjrA==
Hi Brad,
Am Thu, 3 Oct 2024 21:54:02 -0400
schrieb Brad Smith <rainwarrior@xxxxxxxxx>:
> Hello. I was not finished with this, but yes I realize I have not been able
> to work on that branch for several months. Life has been a bit tough and I
> have not prioritized working on this, sorry.
>
> The layouts I had completed I considered complete: US, DE, FR, UK, ES, IT,
> SE, CHFR, and CHDE
>
> Layouts I have not yet researched: FI, NO, DK, SA, NL, CS, HU
At least FI seems to be the same as Swedish, so you can drop that of your
list. I added NL and DK on my own. I never saw a SA TOS, and EmuTOS does
not support it, too, so I think we can ignore that one.
> I wish you had contacted me with a request to make the restructuring you
> wanted instead of just taking it and integrating it without warning, with
> so many modifications. It would have been easier for me to understand what
> changed if you had requested me to do it myself.
Well, what I did was basically a complete rewrite of your patches. Having a
full switch-case statement with all keys for *each* language looked pretty
much too big and unmaintainable to me, it's way easier if we only encode
the differences to the standard mapping. Requesting such a complete rewrite
from you seemed unfair to me, especially since you seemed to be busy with
other stuff nowadays, that's why I went ahead and did this rewrite on my
own. Sorry, I thought you'd rather be happy if you would not need to do
such a rewrite on your own, but I'll make sure that I ask you the next time
in advance.
> I've tried to do a careful review of the changes, and I've made and tested
> a PR, which can be viewed here:
>
> https://github.com/hatari/hatari/pull/36
I can try to have closer look at this at the weekend, but from a first
glance, you're changing too much stuff in one go, so it's difficult to
review and apply this patch:
https://github.com/hatari/hatari/pull/36/commits/a05f01ac1b7949b712d8a9cd326b626dd6bd
Can you split up that work into individual, coherent steps, please?
Thanks,
Thomas