Re: [hatari-devel] Joystick jump/space setting

[ Thread Index | Date Index | More Archives ]


On 6.3.2023 23.25, Matthias Arndt wrote:
Am Mon, 6 Mar 2023 21:09:29 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
On 6.3.2023 20.41, Matthias Arndt wrote:
Am Mon, 6 Mar 2023 19:48:49 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
Looking at joystick handling code in joy.c...

Although "bEnableJumpOnFire2" option is in the config file for all
the joysticks, code seems to respect it only for Joystick 1, why?

I guess no thorough review was done when I commited that piece of
code long years ago?

You may consider this as a bug ofcourse, sorry for causing it.

The idea was that a gamepad with a dedicated jump was more useful
than the autofire option.

Are you saying that jump should be enabled by default (currently it's
disabled by default)?

Or that space key press auto-firing is intentional feature (see my
next mail)?

"Spacebar/second fire button as autofire" was a default option that the
original WinSTon code base already had and Hatari ported that.

Mine was an addition and I think there was a discussion not to
activate officially.

My personal choice would be to offer it is as an option, either
autofire or jump on the second joystick button.

There is separate autofire option for fire buttons, which is visible in the SDL GUI.

However, that has no relation / impact on the button2 *spacebar* emulation "autofiring".

I'm asking about the latter.  Is it intentional, or just bad implementation?

And if it's intentional that those spacebar key press & release events are fired so fast that it's practically impossible for user to have just single press, what's the use-case for it?

It should be working fine except for the given bug and the missing UI

	- Eeo

Mail converted by MHonArc 2.6.19+