|Re: [hatari-devel] Enhanced keymap support|
[ Thread Index |
| More lists.tuxfamily.org/hatari-devel Archives
Your earlier patch series was :
I added :
to authorize several Host (PC) modifiers together.
to match multiple Host (PC) modifiers as explained in keymap_fr_pc.cfg
posted on hatari-devel list on october 5 2022.
to add NO_XXX Guest (ST) modifiers and use them.
All these patches have been renumbered (+1 added to index) giving 0002-xxx,
0003-xxx,...,0015-xxx and added to file enhanced_keymap_patches.tar.gz
posted on hatari-devel list on october 5 2022 with 2 more patches :
to add screen.h include in keymap.c as this include was deleted
(Thomas on october 1 2022) and i did not want than patches
0002-xxx, 0003-xxx,..,0015-xxx report bad offset when applied to
to delete screen.h and change strlcpy added in your earlier patch
series to Str_Copy (change initiated by Thomas on october 1 2022)
Then all the patches may be applied to master in order 0001-xxx to 0016-xxx.
Le 06/10/2022 à 10:52, Eero Tamminen a écrit :
Are there any other changes on top of my earlier patch series, than:
* rebasing it on latest Hatari sources
* updated french keymap file
On 5.10.2022 17.27, Yves Le Berre wrote:
I apologize for the big patch 'keymap.c.patch'. To return to enhanced
keymap patches series :
- I Added a first patch (0001) adding screen.h include in keymap.c
to eliminate offset lines in following patches,
- Then, I added the ordered patches in the series
(renumbered from 0001 - 0014 to 0002 - 0015),
- Then, I added a patch (0016) deleting screen.h include in keymap.c
(and incidentally change strlcpy inserted in patches 0006 and 0009
In attachment, you'll find the files :
1) enhanced_keymap_patches.tar.gz which contains the patches to apply
to master :
2) keymap_fr_pc.cfg which contains the mapping.
Le 03/10/2022 à 17:53, Thomas Huth a écrit :
Am Sun, 2 Oct 2022 15:57:18 +0200
schrieb Yves Le Berre <yves.le_berre@xxxxxxxxx>:
Please don't squash patches together in such a big patch. That makes
Due to Thomas recent changes :
- Reduce our dependencies to screen.h,
- Replace strlcpy() with a better implementation.
I adapted enhanced_keymap patches by rebasing and grouping the patches
by filenames rather by added/modified function.
changes very hard to review.
Eero, you once started looking into this problem, do you still plan to
take care of this? Or don't you have time for this anymore?