| Re: [hatari-devel] macOS: SDL 2.14 build issues and missing PRODUCT_BUNDLE_IDENTIFIER |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: Hatari Development <hatari-devel@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [hatari-devel] macOS: SDL 2.14 build issues and missing PRODUCT_BUNDLE_IDENTIFIER
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 24 Sep 2022 10:16:25 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1664014591; bh=TgYn3Tjg93q12+rwPiL2hgO8TWE8U04+oBHbHJCfqZ0=; h=Date:From:To:Subject:From; b=neHlrgnHIRLHxGZkw1eobDskaQrBEtRlVfgNducJ4hf5yNj4y6yOVYhaCc2CofWEQ 9d52AL1hPUF72/XJhCy2qeuUjt9ZdZUhPzZ18EkgQ7ZpHzNbmKzfPdqNeXoKG8IJ46 lymDSfOv9bO3rkBTboWMIaRBho8xI+LYkZhwv35dXEqxp7Nq4Cpu55+2r118hda+J0 oTdxfrOTdu5pMYUJqFpo9I91duuUxnaOwsMsOTcX4GRSSbZA6XaVcU6cqtOkvYlUP9 /M31RbLavRQ5k2ql1aiqVHHcd/GBOE6Ja4Q4o9eTJW7dgvct+KEBIg3WfVfuDmL3bA R2MYd/M12jo8A==
Am Sat, 24 Sep 2022 09:41:55 +0200
schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> > Am 24.09.2022 um 09:21 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> >
> > Am Sun, 18 Sep 2022 18:07:09 +0200
> > schrieb Andreas Grabher <andreas_g86@xxxxxxxxxx>:
> >
> >>> Am 18.09.2022 um 16:19 schrieb Thomas Huth <th.huth@xxxxxxxxx>:
> > [...]
> >>> Seems like this SDL2Config.cmake is available since SDL v2.0.6 (released in
> >>> 2017), so I assume all recent distros should ship with at least that
> >>> version ... or is anybody still compiling Hatari on an older system that
> >>> does not have at least SDL 2.0.6 yet?
> >>
> >> I also do not understand CMake too well. I created the patch according to this discussion: https://discourse.libsdl.org/t/sdl2-and-cmake-problem-finding-headers/38303/8 <https://discourse.libsdl.org/t/sdl2-and-cmake-problem-finding-headers/38303/8>
> >
> > Hi,
> >
> > FYI, I've updated Hatari now to also use the config provided by the SDL2
> > library instead of using our own FindSDL2.cmake module. Please check
> > whether Hatari still builds fine in your environment.
> >
> > Please note that I did the adaption in a slightly different way compared to
> > Andreas' suggestion - I'm using ${SDL2_LIBRARIES} instead of SDL:SDL since
> > that is said to be more compatible when SDL2 has been build with automake
> > instead of CMake (according to the discussion on their forum here:
> > https://discourse.libsdl.org/t/how-is-sdl2-supposed-to-be-used-with-cmake/31275 )
> > I hope this still works well with the latest build environment on macOS ...
> > Andreas, could you please check?
>
> This seems not wo work on my system. The original problem persists (not finding SDL’s internal headers because of leading „SDL2“ directory in #include).
As discussed off-list with Andreas, it seems like the additional
target_link_libraries() statements are still necessary for the
sub-libraries that we build. I've added them now, together with a
fix on macOS that occurred when compiling without the OSX bundeling,
so I hope we're fine now...
Thomas