Re: [hatari-devel] macOS: SDL 2.14 build issues and missing PRODUCT_BUNDLE_IDENTIFIER -> using SDL2's config for cmake

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Le 24/09/2022 à 12:16, Thomas Huth a écrit :

Hi,

FYI, I've updated Hatari now to also use the config provided by the SDL2
library instead of using our own FindSDL2.cmake module. Please check
whether Hatari still builds fine in your environment.

Please note that I did the adaption in a slightly different way compared to
Andreas' suggestion - I'm using ${SDL2_LIBRARIES} instead of SDL:SDL since
that is said to be more compatible when SDL2 has been build with automake
instead of CMake (according to the discussion on their forum here:
https://discourse.libsdl.org/t/how-is-sdl2-supposed-to-be-used-with-cmake/31275 )
I hope this still works well with the latest build environment on macOS ...
Andreas, could you please check?

This seems not wo work on my system. The original problem persists (not finding SDL’s internal headers because of leading „SDL2“ directory in #include).

As discussed off-list with Andreas, it seems like the additional
target_link_libraries() statements are still necessary for the
sub-libraries that we build. I've added them now, together with a
fix on macOS that occurred when compiling without the OSX bundeling,
so I hope we're fine now...

Hi

just to confirm that after updating with these changes, I see no problem when compiling for linux and also no problem when using mingw to compile Windows 32 bit or 64 bit versions.

So, all our usual target for linux/windows/macos seem to work correctly with the official SDL's config for cmake.

Nicolas

Nicolas



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/