Re: [hatari-devel] The external disassembler is now really external

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Sun, 28 Aug 2022 12:03:28 +0200
schrieb Thorsten Otto <admin@xxxxxxxxxxx>:

> On Sonntag, 28. August 2022 10:29:47 CEST Thomas Huth wrote:
> > Done now, FNOP here:  
> 
> To be honest, i don't quite understand the decision to replace the already 
> working solution, by a bloated library (none of the other architectures that 
> are supported by capstone are needed in Hatari), which is also buggy (atleast 
> for m68k)?

We already have a disassembler in Hatari. Maintaining a second one is
just a waste of resources and space:

1) The previous solution bloated Hatari. The code was more
than 2300 lines of code that now have been removed.

2) We had many cases in the past where the previous disassembler also gave
wrong instructions. Since the code was very hard to maintain (huge
functions with a lot of indentation levels), these were a pain to fix.

3) Since the code was written in a bad maintainable way, it was also a pain
to fix compiler warnings each time a new GCC came around and found new
issues.

At least for me, that disassembly code was more of a nuisance than being a
benefit. Even if Capstone is not perfect yet, people from other projects
will contribute there, too, so the pain of maintainence is (hopefully) much
lower here.

 Thomas