| Re: [hatari-devel] ASAN issues with tests |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] ASAN issues with tests
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Mon, 1 Aug 2022 18:04:01 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1659377043; bh=1iQJFGXYYbcFugS57rNM2W+axJ7XL/WNNx53JBNMT4U=; h=Date:From:To:Subject:From; b=gGHSC9ZIGl4PatxGHq3vpbZQ3Ti/lKNCXiWQNFLmKO2qa8y6zFXT32MA8IqFY0wPs n+XCzVloW5m5fAZHJYPP+SB47lfBNpPPXAeiPa+Q2e2H67DiIhKch7j69M3RH0wM1U Ewl4a6ejtBaw6LjL1xkON+a7V63nir8Urx5wJuJ9ep3cnkS9XtfbOITYTQ4wGLIboK xxr+oQiDqzNNcPlhfLWCtm6fzzgZqqb4ppXbyiNONTABznR1IO0Lrq9ZvuXedwGaDo lL4iQnbrNwPooVXQZVoMm/j9OUZ5JUMylm4rujHTF1hrk8bc+CnGE8isrHniTBvWeV 3NmvR4ry9INMQ==
Am Mon, 1 Aug 2022 19:52:30 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> On 30.7.2022 11.16, Thomas Huth wrote:
> > Ok, I think I've got it now: The problem was that the ST program could have
> > changed the video base address again between the point in time we recorded
> > the VideoBase variable and the point in time the rendering was done in
> > screenConvert.c. So the code in screenConvert.c must not use
> > Video_GetScreenBaseAddr() but has to use the vide base address value that
> > was recorded earlier. I've committed a patch - that will hopefully fix this
> > issue.
>
> You documented it as emulation fix, not emulator one.
Ok, I've moved it around.
> I think Hatari crashes in general are emulator issues, but I also
> started to wonder what actually should happen in this case on real machine.
>
> Will ST just ignore rest of video accesses going out of ST-RAM, or
> generate some kind of exception?
There are no exceptions in this case, the video access are not checked for
validity on the real hardware.
Thomas