| Re: [hatari-devel] Re: Make building the Python GTK+3 user interface conditional. (PR #21) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Re: Make building the Python GTK+3 user interface conditional. (PR #21)
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Mon, 1 Aug 2022 18:12:21 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1659377543; bh=O+DEnKWLC92iX2QjPxXI0LojiK4aSypMDTZ4kn0nWWo=; h=Date:From:To:Subject:From; b=JD997haaoWR6zhBGs6afmn9L/6DkvscW7GNwxu6aIkLenxaF545eGEYPU4AucPmM1 mbfW0+EVDcMwPGn1SAkJuI8a2v6BiKe31lDAl29y1P0IegRHlSVsZYGNcuUOH5ZQPu XF4g3A4xQFjltaIjjQngp2cAgvySFrccNnhW0073zwxfr+6NXWdoZLTQ1P+w6knygW uHG1y6gIT6JuZvVMRwBIjmooAjH6/0TaQc0DDimY5shOhiABsORuhKESwACGKbetr0 Xp2+H/hOuYPn8ZbAM8QWaGtFMjpg98nuW4vIwpl6sfkNxb2eyUg4I9qSOisGSvGo1I tpTdFW1U4QOMg==
Am Sun, 31 Jul 2022 01:48:29 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> On 30.7.2022 9.28, Thomas Huth wrote:
> > could you please have a look at the PR below, please?
>
> I checked the patch.
>
> > Sounds basically ok to me, but wouldn't it be better to probe for the
> > python package instead of introducing a user-selectable switch in the CMake
> > file?
>
> I completely agree.
>
> There should be CMake test that checks whether this works instead:
> ------------
> #!/usr/bin/python3
> import gi
> # use correct version of gtk
> gi.require_version('Gtk', '3.0')
> from gi.repository import Gtk
> from gi.repository import Gdk
> from gi.repository import GdkPixbuf
> from gi.repository import GLib
> ------------
> (code taken from dialogs.py)
Thanks! ... it was a little bit tricky to get the Python-code into
CMakeLists.txt, but I think I've now found a way to do it:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=7464d784485142
Let me know if it does not work as expected.
Thomas