| Re: [hatari-devel] ShellCheck |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] ShellCheck
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 11 Jun 2022 11:11:28 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1654945892; bh=NIOb7lNO9lRjk8TyK7k9x6jWvKmiqXBEFLoiUZ62VBc=; h=Date:From:To:Subject:From; b=eYy9RKUK8i4rkQ8OVu1ZDPi4OnOtvXnqYP3Mf5C9FG9Q+eudRfwvXedeglEWZ125X 8XnrxZXG/f0xsgV35yjogy+r9xWj90DD4B9lkHq0r+QxmlJDO4rfBQ3LMAMODEineO mO4nIxZoBK1zb48EmEH1oR96fVy/RVCECOpyUm+LP3sXAmTBpEI5KjugNGA2V01L9f UuJu3Ae1fP87ojNPWnzJCoG6947NE+mT1XivxLXsvpI6KgwgzOLbTuOrkUzIeQpF1y TT43a28S7QP+Hd/02y6/LPlNbvbAJRtmpPhwUxQqK+sFu8bnNXp6MjWdq9Jhue5Tqt NeL379hiMk2og==
Am Sun, 29 May 2022 22:28:47 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> I've been running "shellcheck" (available from package with the same
> name on Debian and Fedora based distros) on my own Hatari scripts:
> https://github.com/koalaman/shellcheck
>
> It's pretty good at pointing out potential issues, and provides links to
> extensive documentation for every warning it outputs.
>
> It did not reveal anything particularly significant, but I've pushed
> commits that remove almost all things it comments about.
>
> Only things remaining are tests/*/run_test.sh scripts.
>
> Thomas, as those are yours, maybe you could take a look at them at some
> point, e.g. after release?
Done now. Maybe we should add this check to the test suite itself, similar
to the tests/check-bashisms.sh script that we already have? (but IIRC we
didn't wire the checkbashism up into "make tests" suite since there were
some unuseful versions of this program around ... but maybe shellcheck is
more reliable?)
Thomas