Re: [hatari-devel] ShellCheck

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 11.6.2022 14.11, Thomas Huth wrote:
> Am Sun, 29 May 2022 22:28:47 +0300
> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > I've been running "shellcheck" (available from package with the same
> > name on Debian and Fedora based distros) on my own Hatari scripts:
> > 	https://github.com/koalaman/shellcheck
> >
> > It's pretty good at pointing out potential issues, and provides links to
> > extensive documentation for every warning it outputs.
> >
> > It did not reveal anything particularly significant, but I've pushed
> > commits that remove almost all things it comments about.
> >
> > Only things remaining are tests/*/run_test.sh scripts.
> >
> > Thomas, as those are yours, maybe you could take a look at them at some
> > point, e.g. after release?
>
> Done now.

Thanks!


> Maybe we should add this check to the test suite itself, similar
> to the tests/check-bashisms.sh script that we already have? (but IIRC we
> didn't wire the checkbashism up into "make tests" suite since there were
> some unuseful versions of this program around ... but maybe shellcheck is
> more reliable?)

Looking at the shellcheck site, it's pretty actively developed, so I 
have no idea how stable or how many different versions of it are in 
different distro versions, especially older ones.

Safer might be just to add script for it, and a note to release 
checklist to run that and "checkbashism" before release.


	- Eero