Re: [hatari-devel] Setting TOS language / keyboard (was: which version of emutos for next Hatari )

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 22/05/2022 à 00:45, Eero Tamminen a écrit :
> Hi,
>
> 2 weeks gone with no comments?
>
> I'm especially interested whether the TOS check criteria looks OK, i.e. 
> doing the country code setting only for multilanguage TOS (= unmodified 
> EmuTOS 1024k, or older 512k, and TOS v4) versions.
>
> And setting PAL/NTSC based on whether it's US country code, like EmuTOS 
> tos-lang-change tool does.
>
> And whether the LANG thing is actually good idea..
>
> Thomas?

Hi

I was busy fixing sound issues :)

I tried your patches, here're my remarks :

 - the patch depends on keyboard's nKbdLayout to be the same as 
nLanguage ; in my case I never chose a value for nKbdLayout so far, so 
it doesn't work. Also the fact that nKbdLayout has no equivalent in the 
GUI could mean it's often TOS_LANG_UNKNOWN for many people.

 - as nKbdLayout was Falcon/TT specific so far to change nvram, it 
means LANG won't be used when running Hatari in STF mode + emutos 1024k 
(at least I was not able to have emutos start in french that way, 
despite adding some traces to tos.c to confirm LANG was correctly parsed)


In the end, maybe multi language TOS should only depend on LANG value, 
not matter what nKbdLayout contains, unless the user already explicitly 
set a value for language in nvram ?

If no nvram, then as nKbdLayout won't be taken into account it should 
allow your patch to work for stf/ste too I think.

Nicolas