| Re: [hatari-devel] HDC code update patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] HDC code update patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Sat, 19 Mar 2022 20:51:01 +0100
- Authentication-results: strato.com; dkim=none
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1647719461; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=ytbTGIqZr4VdXS0LD8KeRNBsSwcH8CQnT/H2nhLgmCo=; b=MXqmxx8T5mj0YlBJCLhKQUFqWmjlHTC51yhROTiCus2wc24KSrTs9zPmSgOhGxF0fb rbLDUymUjU2UtpilCf1ieKYyYqn/ImqFnDny9NyAQjUmcLAOXFwNrWnjonO5UAYFprQv zHClhJDVOWlHFTeCfJKxLi87n2IWRfPpwva+Kd/gK+ztV8//2DWGs24FMJzSb/7xwN/r esxah/fzOfhe+MQf61/s9eFUjSJmba/8FLpe555ZTSeOOXSrNvr4T5NYFIR5WRFT/nZK EAcuFpPsNKQbI9xgsXuoDkkW+6gAYHQiUqyQE2E+ScySd5HzKS6e+M++/hRPqVMLdiBf wyXg==
It might be a good idea to add a webpage with Hatari development
guidelines. Maybe it already exists, but I don't think so.
> Am Mon, 14 Mar 2022 20:14:37 +0100
> schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
>
> > Hi again,
> >
> > > Main reason for this is that I'd like your commit message to tell reason
> > > for the functional changes you did not mention:
> > > - else if (ctr->opcode == 0x05 || (ctr->opcode >= 0x20 && ctr->opcode <=
> > > 0x7d)) {
> > > + else if (ctr->opcode >= 0x20 && ctr->opcode <= 0x7d) {
> > > ...
> > > - else if (ctr->opcode >= 0x60)
> > > + else if (ctr->opcode >= 0x60 && ctr->opcode != HD_REPORT_LUNS)
> > >
> > > (If it e.g. fixes your earlier commit, it would be nice to give ID for
> > > the fixed commit in the commit message.)
> >
> > Don't get me wrong, but let me just say that the recommended length of git
> > commit messages is 70-75 characters. https://i.stack.imgur.com/uzUqh.png
> > shows that for the Linux kernel the contributors mostly manage to stay
> > within this range.
>
> I think Eero likely meant something like the "Fixes:" line in the Linux
> kernel commit messages. You can also shorten the commit ID to 12 - 16
> characters for this. For example:
>
> Fixes: 5e0da3c1bbe8 ("Add an hexa dump when logging the CDB fields")
>
> HTH,
> Thomas
>
>