| Re: [hatari-devel] HDC code update patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] HDC code update patch
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 19 Mar 2022 19:47:01 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1647719223; bh=FTo5tqs0ogLd/XvOduYXvjSRQ5yCI/q5lqptDtL368I=; h=Date:From:To:Subject:From; b=WMlMtFBYj1+kE0eELCL/4HgVPDRUnKus1CBRll1hcoNULOcGr5NE3iaNJGFUM84TX 97vUNXC6fL6q+NLaFtzO2c1ohuTWWZtXcn/iygUhAk7akg8cUoYSlOn6EdNSHLy3cD TF0QHW+AY6XUoT03EgeKbSlLpiYs79zCxO0LS1ljRhCnYT6dR7JnXeBr6Uwnv/2niz 5Is+GS1/NyODXykyRyBdzFfkcT3BsAtyCKPycjksWxWekzzgkzCA9t0Mluh1luHeeC BbzbHsb+Y28PeHwsKA2YG7w5UZyeZDcF49JmSDPb/2e6M/wvkkbemdxNMSWMO+Wp6K +PjhjymvioOEw==
Am Mon, 14 Mar 2022 20:14:37 +0100
schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
> Hi again,
>
> > Main reason for this is that I'd like your commit message to tell reason
> > for the functional changes you did not mention:
> > - else if (ctr->opcode == 0x05 || (ctr->opcode >= 0x20 && ctr->opcode <=
> > 0x7d)) {
> > + else if (ctr->opcode >= 0x20 && ctr->opcode <= 0x7d) {
> > ...
> > - else if (ctr->opcode >= 0x60)
> > + else if (ctr->opcode >= 0x60 && ctr->opcode != HD_REPORT_LUNS)
> >
> > (If it e.g. fixes your earlier commit, it would be nice to give ID for
> > the fixed commit in the commit message.)
>
> Don't get me wrong, but let me just say that the recommended length of git
> commit messages is 70-75 characters. https://i.stack.imgur.com/uzUqh.png
> shows that for the Linux kernel the contributors mostly manage to stay
> within this range.
I think Eero likely meant something like the "Fixes:" line in the Linux
kernel commit messages. You can also shorten the commit ID to 12 - 16
characters for this. For example:
Fixes: 5e0da3c1bbe8 ("Add an hexa dump when logging the CDB fields")
HTH,
Thomas