Re: [hatari-devel] Trailing whitespace removal

[Thomas Huth <th.huth@xxxxxxxxx>]

Am Tue, 13 Oct 2020 13:10:00 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:

> Hi,
> 
> Would it be OK to commit changes that remove trailing whitespace from 
> all code, except:
> - src/gui-osx/ (may be partly auto-generated)
> - src/uae-cpu/ (not gonna change anymore)
> - src/cpu/ (comes from another project)
> ?
> 
> Line counts for the changes look following:
> -------------------------------------------
> [PATCH 1/6] Remove trailing white space from test code
>   12 files changed, 23 insertions(+), 23 deletions(-)
> -------------------------------------------
> [PATCH 2/6] Remove trailing white space from debug & tools code
>   19 files changed, 90 insertions(+), 90 deletions(-)
> -------------------------------------------
> [PATCH 3/6] Remove trailing white space from Falcon code
>   5 files changed, 106 insertions(+), 106 deletions(-)
> -------------------------------------------
> [PATCH 4/6] Remove trailing white space from SDL GUI code
>   5 files changed, 536 insertions(+), 536 deletions(-)
> -------------------------------------------
> [PATCH 5/6] Remove trailing white space from includes
>   9 files changed, 20 insertions(+), 20 deletions(-)
> -------------------------------------------
> [PATCH 6/6] Remove trailing white space from Hatari main code
>   48 files changed, 326 insertions(+), 326 deletions(-)
> -------------------------------------------

Not sure ... that looks like quite a lot of code churn for little use?
I normally only change that for files that I want to edit afterwards
anyway, and also only if it really bugs me...

I think we should
a) wait for the release first, to avoid that we have accidential
regressions due to this (it's unlikely, but still could happen)
b) add a statement to doc/coding.txt first that says that trailing
white spaces should be avoided.

 Thomas