Re: [hatari-devel] AES/VDI breakpoints (was: Add some NVDI function names)

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Am 14. Oktober 2020 00:01:55 MESZ schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
Hi Thorsten,

I've now pushed support that allows tracing
AES & VDI calls with extra info like this:
b VdiOpcode = 8 :quiet :info vdi # v_gtext
b AesOpcode = $32 :quiet :info aes # form_do


On 10/12/20 12:28 PM, Eero Tamminen wrote:
On 10/12/20 3:38 AM, Thorsten Otto wrote:
On Sonntag, 11. Oktober 2020 22:54:18 CEST Eero Tamminen wrote:
if VDI_Info() doesn't provide all the
information you need, could you provide a patch
adding them?

VDI_Info() currently relies on printing values that were saved at the
last VDI
call. What i was thinking about was to print also the *contents* of
the intin
and ptsin arrays. But that cannot reliabe be done much later (look at the
bindings in gemlib for example, most of the time the values are on the
stack,
and are not available anymore when the function doing the call is left).

Right, so the data needs to be copied, not the pointers to them.


So i don't think that it currently makes sense to change it,
if that all is going to be redesigned. It's also not that real
urgent, i would probably wait for this until after the release.

You could use something like the attached patch as
starting point. See TODO comments in it.

Arrays could be either dynamically allocated, or
be static, with some upper limit of how many
items are stored to them. Limit could be selected
based on how much information it makes sense to
print before screen output starts to become
unreadable.


- Eero


Fyi, this caused a build failure:
https://gitlab.com/huth/hatari/-/jobs/794357301

Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/