| Re: [hatari-devel] Re: IDE byte swapping options |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
Hi,
On 10/16/18 8:00 AM, Thomas Huth wrote:
Am Sun, 14 Oct 2018 11:47:09 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
On 10/13/18 6:33 PM, Thomas Huth wrote:
No, does not look OK. Please don't change "it is" to "it's" (since
that is colloquial) and don't use single generic names for things
that are related to a specific subsystem. Something like
"--ide-swap" would be more adequate.
Ok, I pushed the patch with the requested changes.
(I tried earlier --ide-byteswap, but that was definitely too long,
--ide-swap is much better.)
Note: Hatari command line options are needed to add features to the
Python UI, and as long as MacOS UI is missing support for the
feature, people there need command line options with that too.
Eero, don't tell me what's necessary. I would have added this CLI option
sooner or later, too. It's just that I'm currently incredibly short in
spare time again.
What I meant is that I needed the command line feature, so I
thought to help us both by doing the easy part of the feature.
(Unfortunately I went wrong in refactoring python-UI dialogs afterwards,
so I didn't get into adding byteswap support to disk dialog last
weekend. Note sure when I have next time to attempt the refactoring.)
But if that's such a big problem for you, then it's
maybe better if I do not add any new features to Hatari anymore.
I think it should be obvious that we all appreciate each others'
contributions to Hatari.
If I say something stupid (= be "Captain Obvious"), please try to
ignore it instead of being offended.
(I read "colloquial" in your earlier mail as "unprofessional", so
I first got annoyed myself. Regardless of whether more colloquial
language suits Hatari documentation, those changes didn't belong to
the patch though.)
By the way, while we're speaking of doing our homework properly: Please
fix the HTML bugs that you've introduced in the manual (i.e. please
check your HTML with https://validator.w3.org before you push it to the
repository). Thanks!
Thanks, I hadn't noticed those. I commited a fix.
Is validator available also as offline Linux program so that it could
be used in a build test, or is it available only as a web service?
If latter, release checklist could have a step for running
the validator.
There isn't currently such list, but I could add one to docs.
What else should be in Hatari release checklist?
- Eero