Re: [hatari-devel] Re: IDE byte swapping options

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 10/13/18 6:33 PM, Thomas Huth wrote:
> No, does not look OK. Please don't change "it is" to "it's" (since that is colloquial) and don't use single generic names for things that are related to a specific subsystem. Something like "--ide-swap" would be more adequate.

Ok, I pushed the patch with the requested changes.

(I tried earlier --ide-byteswap, but that was definitely too long, 
--ide-swap is much better.)

Note: Hatari command line options are needed to add features to the 
Python UI, and as long as MacOS UI is missing support for the feature, 
people there need command line options with that too.


	- Eero

>   Thomas
>
>
> Am 13. Oktober 2018 00:50:39 MESZ schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > Hi Thomas,
> >
> > On 10/3/18 10:00 AM, Thomas Huth wrote:
> > > Am Sun, 23 Sep 2018 20:17:56 +0300
> > > schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > > > If yes, attached patch "should" implement such option for IDE
> > > > partition counting.  If it works fine, same options can be used
> > > > to toggle swapping for rest of IDE handling too.
> > >
> > > Thanks for the patch, that's a first step... but actually, I think
> > this
> > > area (especially the HD dialog in the GUI) needs a major clean-up,
> > e.g.
> > > I also need to add SCSI setup to the GUI, add support for multiple
> > ACSI
> > > images, fix the nomenclature for IDE ("master" and "slave" is
> > > nonstandard, the official terms are IDE 0 and IDE 1), etc.
> > >
> > > Using "--byteswap master" to only enable byteswapping is also a bad
> > > idea - what if a user already enabled byteswapping in the config file
> > > and wants to disable it on the CLI again?
> > >
> > > So I'd appreciate if you could hold back your patch, I'll take care
> > of
> > > this, I just need to find some spare time to work on this...
> >
> > You've added the functionality and SDL GUI code, but command line
> > option seems to be still missing.
> >
> > Does the attached patch look OK?
> >
> >
> > 	- Eero