Re: [hatari-devel] Logging prefixes

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 05/05/2018 11:00 PM, Thomas Huth wrote:
> Am Sun, 29 Apr 2018 20:16:28 +0300
> schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> > Everything relevant should now be converted to use logging
> > except for CPU core / floppy / hd image code.
> >
> > Logging functions add now log level prefix to all log
> > messages so it's easy to seem what isn't using logging
> > functions.
>
> Sounds like a good idea. But could we maybe change the prefixes so that
> they all have the same length, i.e. that the real messages are all
> aligned to a column?
Mis-alignment was by design, to make different log level messages
stand out better from each other.

(This is mainly for warning messages, errors are normally
drastic enough to be obvious, but warnings could be easily
missed from Hatari output if one isn't especially looking
for them.)


> I think that would look nicer.

There's nothing in the messages themselves that would
benefit from aligning between different log levels.


> We could for example use:
> FATAL:
> ERROR:
> WARN :
> INFO :
> TODO :
> DEBUG:

With that, color could be used for differentiation, but that
would be otherwise nasty (unless it's disabled if Hatari
detects that output isn't going to console).

Thoughts?


	- Eero