| Re: [hatari-devel] Logging prefixes (was: Recent Hatari change problems) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Logging prefixes (was: Recent Hatari change problems)
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 5 May 2018 22:00:44 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1525550446; bh=EDX0om6+0z7EMxwo3bMsKTqQA7D/j2Yody4v4Yh9zVg=; h=Date:From:To:Subject:From; b=ZtPTM8LfnjhWbyS1odhae/B4GSV+DJBrgofbjFI/EGDQSb1olwQJJ+6wwMazYKh6o AYZaq4TtS8s5dy7nXYpFvVZphu+zOkMlsYCrro7n3SKWmgyNyJC5oqYwPd4oRj2lCM ETRabO/44TYi8oOUj+mG1e+gpp2xiPQ5YNYoQv3qTsNA4gfJc1y+VIsVD66SN2q1m4 CouyfLiNQwdTlDf82b9MqvD87bSk2rzyXezneUJ1/NPsE5CcmQMvs0bc4A0oJI8iuX grAFcN5Zp7+lBQYrhRX8j7VOVcHMaXTPo1iM5M39WMNnoPQQQIr6fc9WsDHdGwbe+0 cVnZpBOuzm5Hw==
Am Sun, 29 Apr 2018 20:16:28 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> Hi,
>
> On 04/28/2018 01:07 AM, Thomas Huth wrote:
> > Am Wed, 25 Apr 2018 01:17:59 +0300
> > schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
> >> I commited updated version of the change and some other
> >> output reductions for the default log level.
> >>
> >> Few of these probably should also be using Log_Printf():
> >> grep printf src/*.c|grep -i warn
> >
> > Yes, they need closer manual inspection, but we should likely
> > convert them to Log_Printf, too.
>
> Done, also to many other places. Please mail if you notice
> anything funky.
>
> Everything relevant should now be converted to use logging
> except for CPU core / floppy / hd image code.
>
> Logging functions add now log level prefix to all log
> messages so it's easy to seem what isn't using logging
> functions.
Sounds like a good idea. But could we maybe change the prefixes so that
they all have the same length, i.e. that the real messages are all
aligned to a column? I think that would look nicer. We could for example
use:
FATAL:
ERROR:
WARN :
INFO :
TODO :
DEBUG:
Just my 0.02 €.
Thomas