Re: [hatari-devel] cmake doesn't detect correctly the readline library on osx.

[benoît tuduri <benoit.tuduri@xxxxxxxxx>]

Hello,

It's a path problem, I guess (attachment 01_cmake01_cmake_log.txt
(trace log cmake detection)) :

During the compilation of test program to enable the detection of
"rl_filename_completion_function", it report an error "
readline.h:35:12: fatal error: 'readline/rlstdc.h' file not found "
(attachment 02_CMakeError.log)

The readline.h (attachements 03_head_readline.txt) file contains a
macro READLINE_LIBRARY. This macro is not set but in my case, it
should be done but not and the else branch is taken. The consequencies
is a snowball effect, the bad includes are used, the compilation test
program fail and the detection too.

I don't know how fix it. If you had an idea... :-) (certainly force in
my case READLINE_LIBRARY=1 but maybe for you, it will destroy the
detection for you)

Regards,

2018-02-15 23:46 GMT+01:00 Troed Sångberg <troed@xxxxxxxxxxx>:
> Hi,
>
> I agree those values look just fine. What does CMakeFiles/CMakeError.log say about why it didn't find it?
>
> regards,
> Troed
>
>
> -------- Original Message --------
>  On February 15, 2018 10:43 PM, benoît tuduri <benoit.tuduri@xxxxxxxxx> wrote:
>
>>Hello,
>>
>> Troed, I prefixed the important value by the sign --> . As you can
>>remark, the path is in my home directory and the
>> "rl_filename_completion_function" (without quotes) is in readline.h
>> file.
>
>

#if !defined (_READLINE_H_)
#define _READLINE_H_

#ifdef __cplusplus
extern "C" {
#endif

#if defined (READLINE_LIBRARY)
#  include "rlstdc.h"
#  include "rltypedefs.h"
#  include "keymaps.h"
#  include "tilde.h"
#else
#  include <readline/rlstdc.h>
#  include <readline/rltypedefs.h>
#  include <readline/keymaps.h>
#  include <readline/tilde.h>
#endif

/* Hex-encoded Readline version number. */
#define RL_READLINE_VERSION 0x0700      /* Readline 7.0 */
#define RL_VERSION_MAJOR    7
#define RL_VERSION_MINOR    0

Attachment: 02_CMakeError.log
Description: Binary data

-- The C compiler identification is AppleClang 8.0.0.8000038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test MUDFLAP_AVAILABLE
-- Performing Test MUDFLAP_AVAILABLE - Failed
-- Found SDL2: /Users/bento/homebrew/lib/libSDL2main.a;/Users/bento/homebrew/lib/libSDL2.dylib;-framework Cocoa  
-- Found MATH: /usr/lib/libm.dylib  
-- Found READLINE: /Users/bento/homebrew/lib/libreadline.dylib  
[±] READLINE_FOUND =>  TRUE
[±] READLINE_LIBRARY =>  /Users/bento/homebrew/lib/libreadline.dylib
[±] READLINE_INCLUDE_DIR =>  /Users/bento/homebrew/include/readline
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found
-- Found TERMCAP: /usr/lib/libtermcap.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found
-- Found Curses: /usr/lib/libcurses.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found
-- Found ZLIB: /usr/lib/libz.dylib (found version "1.2.5") 
-- Found PNG: /Users/bento/homebrew/lib/libpng.dylib (found version "1.6.34") 
-- Found PORTAUDIO: /Users/bento/homebrew/lib/libportaudio.dylib