[hatari-devel] cmake doesn't detect correctly the readline library on osx.

[benoît tuduri <benoit.tuduri@xxxxxxxxx>]

Hello,

I still have detection problems for readline with cmake, Look my cmake listing :

      [1] libedit detected like readline => it's ok , readline is
detected (attachement 01_log.txt)
      [2] readline 7.0.3
Note:  I forced to link my system to use the readline 7.0.3 :
$ brew link --force readline
      (attachement 02_log.txt)

I investigate why cmake is able to detect the right libreadline (
/Users/user/homebrew/lib/libreadline.dylib ) but not
rl_filename_completion_function. (attachment 03_log.txt)

To solve this detection problem, I changed some stuff in
FindReadme.cmake (attachment
check_function_exists_cmake_rl_filename_completion_function.patch)

And the detection works like a charm : (attachment 04_log.txt)

I hope the patch will not break under linux or windows or newer
versions of osx or macports.

Could you give me a feedback ?

Regards,

-- The C compiler identification is AppleClang 8.0.0.8000038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test MUDFLAP_AVAILABLE
-- Performing Test MUDFLAP_AVAILABLE - Failed
-- Found SDL2: /Users/user/homebrew/lib/libSDL2main.a;/Users/user/homebrew/lib/libSDL2.dylib;-framework Cocoa  
-- Found MATH: /usr/lib/libm.dylib  
-- Found READLINE: /Users/user/homebrew/lib/libreadline.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - found

Libraries summary :
-------------------

  - sdl :   using SDL2 v2.0.7
  - readline :  found, enables history/completion in the debugger
  - zlib :  found, allows to use zip/gz files directly
  - png :   found, allows to compress screenshot/avi files using png
  - portaudio : found, enables the microphone input in Falcon mode
  - portmidi :  found, required for (non-Linux) MIDI support
  - capsimage : v5 not found, install it to use .IPF, .RAW and .CTR disk images

$ grep -Ri rl_filename_completion_function  /Users/user/homebrew/Cellar/readline/7.0.3_1/include/
/Users/user/homebrew/Cellar/readline/7.0.3_1/include//readline/readline.h:extern char *rl_filename_completion_function PARAMS((const char *, int));
/Users/user/homebrew/Cellar/readline/7.0.3_1/include//readline/readline.h:   NULL means to use rl_filename_completion_function (), the default
/Users/user/homebrew/Cellar/readline/7.0.3_1/include//readline/readline.h:   rl_completion_entry_function (rl_filename_completion_function). */

Linking /Users/user/homebrew/Cellar/readline/7.0.3_1... 16 symlinks created
I'm relaunch cmake :
-- The C compiler identification is AppleClang 8.0.0.8000038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test MUDFLAP_AVAILABLE
-- Performing Test MUDFLAP_AVAILABLE - Failed
-- Found SDL2: /Users/user/homebrew/lib/libSDL2main.a;/Users/user/homebrew/lib/libSDL2.dylib;-framework Cocoa  
-- Found MATH: /usr/lib/libm.dylib  
-- Found READLINE: /Users/user/homebrew/lib/libreadline.dylib 
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found
-- Found TERMCAP: /usr/lib/libtermcap.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found
-- Found Curses: /usr/lib/libcurses.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - not found

Libraries summary :
-------------------

  - sdl :   using SDL2 v2.0.7
  - readline :  not found, install it to enable debugger history/completion
  - zlib :  found, allows to use zip/gz files directly
  - png :   found, allows to compress screenshot/avi files using png
  - portaudio : found, enables the microphone input in Falcon mode
  - portmidi :  found, required for (non-Linux) MIDI support
  - capsimage : v5 not found, install it to use .IPF, .RAW and .CTR disk images

-- The C compiler identification is AppleClang 8.0.0.8000038
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Performing Test MUDFLAP_AVAILABLE
-- Performing Test MUDFLAP_AVAILABLE - Failed
-- Found SDL2: /Users/user/homebrew/lib/libSDL2main.a;/Users/user/homebrew/lib/libSDL2.dylib;-framework Cocoa  
-- Found MATH: /usr/lib/libm.dylib  
-- Found READLINE: /usr/lib/libreadline.dylib  
-- Looking for rl_filename_completion_function
-- Looking for rl_filename_completion_function - found
... etc etc ..

Libraries summary :
-------------------

  - sdl : using SDL2 v2.0.7
  - readline : found, enables history/completion in the debugger
  - zlib : found, allows to use zip/gz files directly
  - png : found, allows to compress screenshot/avi files using png
  - portaudio : found, enables the microphone input in Falcon mode
  - portmidi : found, required for (non-Linux) MIDI support
  - capsimage : v5 not found, install it to use .IPF, .RAW and .CTR disk images

Attachment: check_function_exists_cmake_rl_filename_completion_function.patch
Description: Binary data