patch for macOS screenshot dir (Was: [hatari-devel] Screenshots are saved in Hatari installation directory)

[Troed Sångberg <troed@xxxxxxxxxxx>]

Hi all,

Thanks for the quick testing! Patch attached.

I've been creative in how to add an Objective-C function "to" paths.c, and decided upon adding the declaration to paths.h as usual and the implementation to a new file called paths.m. All other Objective-C files have capitalized filenames, but none of them are "just" an added function to what's otherwise an existing C-implementation. Comments welcome.

regards,
Troed
​

-------- Original Message --------
 On February 17, 2018 12:47 AM, Bob Carpenter <hatari@xxxxxxxxxx> wrote:

>Troed,
>
> Yes, your screenshot capture change does work on macOS High Sierra. I tried three different screen capture directories and it worked each time. I had to reboot my Mac rather than simply log out in order for the change to take effect. From what I read, I should’ve been able to log out or use “killall SystemUIServer” from Terminal in order for the new preference to take effect, but it didn’t work for me.
>
> I saw the known bug, but it sounds like you have already fixed that in a later version.
>
> Bob C
>
>
>>On Feb 16, 2018, at 4:02 PM, Troed Sångberg troed@xxxxxxxxxxx wrote:
>>Hi Anders,
>>Thanks for testing :)
>>There is a known bug in that test version, it will not advance grab0001 -> grab0002 etc. I hadn't switched out all calls to getworkingdir, now done.
>>If it works for Bob with modified location preference I'll submit it as a patch. It was ... interesting, mixing C and Objective-C. Nicolas will have to scold me if my solution isn't clean enough ;)
>>regards,
>> Troed​
>> ​
>>-------- Original Message --------
>> On February 16, 2018 10:43 PM, Anders Eriksson ae@xxxxxx wrote:
>>>Hi!
>>>I've tested this new macOS fix and it appears to work correctly, thanks!
>>> It was a bit messy before screenshots, landed everywhere because I
>>> sometime start Hatari with scripts, sometime not. More than often I just
>>> took the macOS window-screenshot instead :)

Attachment: screenshotdir.diff.zip
Description: Zip archive