Re: [hatari-devel] Screenshots are saved in Hatari installation directory

[Troed Sångberg <troed@xxxxxxxxxxx>]

I have looked into how to add this today and plan to do it during the weekend. Currently I think the cleanest solution is to add a new screenshot-path to paths.c which would be initialized to working directory on non-Mac platforms and the result of the contents of the com.apple.screencapture.plist if it exists or ~/Desktop/ if it doesn't on macOS.

ScreenSnapShot_SaveScreen in screenSnapShot.c would then be changed to do Paths_GetScreenshotDir() instead of Paths_GetWorkingDir()

regards,

Troed

-------- Original Message --------

On February 16, 2018 4:50 PM, Jérôme Vernet <vernet.jerome@xxxxxxxxxx> wrote:

If Hatari Linux  capture function accept a path, it could be done.

Bad luck, I m in holiday, weather is too bad to skiing and I cannot get MacBook to life....

Envoyé de mon iPhone

Le 16 févr. 2018 à 13:20, Troed Sångberg <troed@xxxxxxxxxxx> a écrit :

Thanks Bob, I didn't know it could be changed. You're right.

/Troed

Sent from ProtonMail mobile

-------- Original Message --------

On Feb 16, 2018, 13:17, Bob Carpenter < hatari@xxxxxxxxxx> wrote:

Troed, Jerome,

It would be great if one of you wanted to work on this. However, if you do this, I would ask you to query the macOS system default screenshot directory rather than assuming it is ~/Desktop. That is because there are utilities (for example, TinkerTool) that allow you to change this value. You can also run a defaults command from Terminal to do this. 

If we support this, it should save screenshots exactly where the macOS user requested them to be saved which may be different than the system default. 

Bob C

On Fri, Feb 16, 2018 at 4:10 AM Troed Sångberg <troed@xxxxxxxxxxx> wrote:

If we don't want to add UI specifically for this, and don't see a need for other platforms, then I suggest adding macOS specific code that simply saves to ~/Desktop/ instead of the working directory.

That's where macOS saves screenshots taken using the built in OS screenshot mechanism, so it's somewhat more expected by macOS users already.

regards,

Troed 

-------- Original Message --------

On February 16, 2018 10:40 AM, Jérôme Vernet <vernet.jerome@xxxxxxxxxx> wrote:

Hello

As I don't put Hatari in the Application folder, I never though that could be a problem.

I can add a directory chooser to select a default folder where to save capture.

It's the case for Video Record, isn't it ?

But when my MB will be back, didn't ' boot better this morning....

Envoyé de mon iPhone

Le 15 févr. 2018 à 23:51, Sebastien Laborie <sebastien-laborie@xxxxxxxxx> a écrit :

Hi Hatarians,

 

Please find hereafter the description of a new bug:

 

Hatari Version: 2.1.0_3_osx

Host OS: macOS 10.13.3

Language: French

Description : Screenshots are saved in Hatari installation directory.

Steps to reproduce:

- Install Hatari in a folder, run the emulator, take screenshots and verify that these screenshots (grabxxxx.png files) are saved in that foder.

- Do the same operation with the Applications folder (install Hatari there) and check that screenshots are now saved in the Applications folder!

This is a bit... unexpected (for macOS users at least :) )

 

Cheers,

 

Sebastien