Re: [hatari-devel] cmake doesn't detect correctly the readline library on osx.

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 13/02/2018 à 23:17, benoît tuduri a écrit :
> Hello,
>
> I still have detection problems for readline with cmake, Look my cmake listing :
>
>        [1] libedit detected like readline => it's ok , readline is
> detected (attachement 01_log.txt)
>        [2] readline 7.0.3
> Note:  I forced to link my system to use the readline 7.0.3 :
> $ brew link --force readline
>        (attachement 02_log.txt)
>
> I investigate why cmake is able to detect the right libreadline (
> /Users/user/homebrew/lib/libreadline.dylib ) but not
> rl_filename_completion_function. (attachment 03_log.txt)
>
> To solve this detection problem, I changed some stuff in
> FindReadme.cmake (attachment
> check_function_exists_cmake_rl_filename_completion_function.patch)
>
> And the detection works like a charm : (attachment 04_log.txt)
>
> I hope the patch will not break under linux or windows or newer
> versions of osx or macports.
>
> Could you give me a feedback ?

Hi

your patch is reverting the patch that Troed posted a few days ago, 
where cmake's doc states that check_functions_exists is deprecated and 
check_symbol_exists should be used instead.

If you want to see what's going wrong, look at CMakeFiles/CMakeError.log 
after running cmake ; it should contain some logs about the readline 
detection.

Nicolas