| Re: [hatari-devel] Compiler warnings |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Compiler warnings
- From: David Savinkoff <dsavnkff@xxxxxxxxx>
- Date: Thu, 10 Mar 2016 15:07:41 -0700 (MST)
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=telus.net; s=neo; t=1457647661; bh=afRxbAHFMxA8MRpbnyJooOCBg/Zacfj967GYso/5iqY=; h=Date:From:To:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type:Content-Transfer-Encoding; b=l1s1FSYZL19ba1YB+vRFAjPBuREuxxO6vhEQtuiy38cS2mG6ei7bPWFTaK7/tT7iS lMKlmKiaaMgOh8sl0Y8R+8EBMYluDI9E4SXfNvYqeTLnvxJnTANzilXFRjGpbntAbk 4k/F7TsapjzEKMmXG3eiRvKUILPtcV2tWe4wCmf6BEL4Rptt/h8vGa4tucIk7F3/Lc rnl7qGiqRzQwWrVVDCpQ7UPOTkrV/IgaS4yJd6h73cwqqrdRzjYLGcW9UxG1DeZf8n 2NIUFx9qXKSySuMsu6gJrJWBOKZ1C/9MlCKV/l58eOZKJBxPiGmpS1J1DCjt+v7Lye aO58a6qeJtvPg==
- Thread-index: EI6XO6sbigFaJNu24+xwgJnbVQX5wA==
- Thread-topic: Compiler warnings
----- Thomas Huth wrote:
> On 08.03.2016 22:10, David Savinkoff wrote:
> > Hi,
> >
> > I compiled Hatari and got these two warnings:
> >
> > 1) Interesting:
> > /hatari.6106/src/gui-sdl/dlgFileSelect.c: In function ‘SDLGui_FileSelect’:
> > /hatari.6106/src/gui-sdl/dlgFileSelect.c:671: warning: passing argument 4 of ‘scandir’ from incompatible pointer type
>
> IMHO that sounds like a wrong warning, since the prototype of filesort()
> matches the specification in the man-page of scandir().
It is good you looked at the code, because I didn't want to evaluate this
function call for correctness.
>
> What compiler version are you using? And which OS are you compiling for?
CentOS 5, gcc 4.1 or thereabouts.
> > 2) I did not check this one:
> > /hatari.6106/src/keymap.c:62: warning: type qualifiers ignored on function return type
>
> Not 100% sure, but I think that "const" here indeed does not make much
> sense. Unless somebody objects, I'm going to remove it.
>
> Thomas
>
>
>