Re: [hatari-devel] 1.8.0 Video recording cropping

[Anders Eriksson <ae@xxxxxx>]

On Mon, 4 Aug 2014, Nicolas Pomarède wrote:

> Le 04/08/2014 10:31, Nicolas Pomarède a écrit :
> > Le 04/08/2014 00:19, Anders Eriksson a écrit :
> > > Hi,
> > >
> > > just a short notice about 1.8.0 video recording. It appears to crop the
> > > video wrong. So I did some tests with both 1.7.0 and 1.8.0 to make sure.
> > > Max resolution were set to 416x288 and 832x576 (pixel double).
> > >
> > > The recorded frame sizes:
> > >
> > > 1.8.0: 416x268 and 832x540
> > > 1.7.0: 416x276 and 832x552
> > >
> > > So 1.7.0 saves the entire visible frame with all scanlines (and even two
> > > extra at the bottom) while 1.8.0 cuts away some lines, and even
> > > different amount of lines depending on max res setting.
> > >
> > > Of course recording is with "Crop statusbar" checked. So maybe there are
> > > some calcs that goes wrong now with the bigger statusbar?
> >
> > Hi,
> >
> > good point, it's indeed possible the cropping is not good anymore with
> > the 2 lines at the bottom.
> > I will check that.
>
> I tried to record or save a screenshot with or without cropping with 1.8.0, 
> and I didn't see any problem : bottom bar is correctly removed, this is also 
> with max resolution set to 832x576.
>
> But maybe this is visible only when program uses overscan ? Can you send a 
> screenshot for both casse (screenshot should crop the same way as avirecord) 
> ?  (in my case I get 832x576 png without cropping and 832x540 with cropping)

Hi,

yes the statusbar is removed, but it's removing more than just the 
statusbar.

As you write, your image is only 832x540 (that's 270 Atari lines) when it 
should be 552 lines like in Hatari 1.7.0 (and earlier).

Without zoom it is even less; only 268 lines remain when there should be 
276 like in 1.7.0.


But I found the source of the problem now. "Max zoomed win" must be 
increased above 288/576 (I tested with 312 now) and then it comes back to 
recording 276 scanlines video.

I was too dumb to realise that "Max zoom win" was not about the Atari max 
size, but Atari + SDL interface max size. So to put good values in 
the "Max zoom win" you need to measure the pixel amount of the SDL 
statusbar with a graphics tool, add it to the Atari resolution, or you'll 
get the wrong setup. Not the best case of a user friendly setting perhaps.


So scrap the bug report, the problem lies with using 
configurations/knownledge from previous versions of Hatari. Thanks for 
looking into it.

--
Anders Eriksson
ae@xxxxxx     http://www.dhs.nu/
ae@xxxxxxxxx  http://www.atari.org/