Re: [hatari-devel] Disasm_SetCPUType()

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 24/08/2014 13:12, Eero Tamminen a écrit :
> Hi,
>
> I noticed this in recent disassembler changes:
>
> +void Disasm_SetCPUType ( int CPU , int FPU )
> +{
> +	optionCPUTypeMask = 0;
> +
> +	if ( ( FPU == 68881 ) || ( FPU == 68882 ) )
> +		optionCPUTypeMask |= MC_FPU;
>
> However, these are the FPU types:
> #if ENABLE_WINUAE_CPU
> typedef enum
> {
>    FPU_NONE = 0,
>    FPU_68881 = 68881,
>    FPU_68882 = 68882,
>    FPU_CPU = 68040
> } FPUTYPE;
> #endif
> ...
>    FPUTYPE n_FPUType;
>
> So shouldn't the check be:
> 	if (FPU != FPU_NONE)
> ?

Hi,

no because 68kDisasm.c has some slightly different types for CPU/FPU 
than UAE/WinUAE and there's no equivalent for FPU_CPU. Choosing 68040 
will use the FPU, but that's because the FPU is part of the 68040, not 
sometimes optionnal as for the 68020/30.

> 	- Eero
>
> PS. I also think that all-caps names should be reserved
> for pre-processor stuff, macros & defines.  Should I
> updated coding.txt?

I used caps for CPU / FPU because they're acronyms and as such are often 
written in all caps. I don't think this require a change to coding.txt.