[hatari-devel] Disasm_SetCPUType()

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

I noticed this in recent disassembler changes:

+void Disasm_SetCPUType ( int CPU , int FPU )
+{
+	optionCPUTypeMask = 0;
+
+	if ( ( FPU == 68881 ) || ( FPU == 68882 ) )
+		optionCPUTypeMask |= MC_FPU;

However, these are the FPU types:
#if ENABLE_WINUAE_CPU
typedef enum
{
  FPU_NONE = 0,
  FPU_68881 = 68881,
  FPU_68882 = 68882,
  FPU_CPU = 68040
} FPUTYPE;
#endif
....
  FPUTYPE n_FPUType;

So shouldn't the check be:
	if (FPU != FPU_NONE)
?

	- Eero

PS. I also think that all-caps names should be reserved
for pre-processor stuff, macros & defines.  Should I
updated coding.txt?