Re: [eigen] Specializing max_coeff_visitor for some number types

[ Thread Index | Date Index | More Archives ]

On 17.08.2014 19:34, Marc Glisse wrote:
Any comment on this patch?

Hi Marc,

sorry I forgot about this thread, so thanks for the reminder.

As no further objections arose to your patch, I'll commit it soon.
I think adding some documentation somewhere here would be nice:


On Sun, 22 Jun 2014, Marc Glisse wrote:


here is a new version of the patch.

I could have made abs_knowing_score safe against users specializing
scalar_score_coeff_op as a derived class of a default
scalar_score_coeff_op for a different type, but I don't think it is
necessary. Also, I don't really know where to put abs_knowing_score,
it is not a unary functor, but moving it far from
scalar_score_coeff_op seems strange. And should it appear in the doc?
For now I made it so it doesn't. I rely on the compiler eliminating
dead code for abs_knowing_score, making the access to the coefficient
lazy is more complicated and, I think, unnecessary.

Dipl.-Inf., Dipl.-Math. Christoph Hertzberg
Cartesium 0.049
Universität Bremen
Enrique-Schmidt-Straße 5
28359 Bremen

Tel: +49 (421) 218-64252

Mail converted by MHonArc 2.6.19+