Re: [eigen] Specializing max_coeff_visitor for some number types |

[ Thread Index | Date Index | More lists.tuxfamily.org/eigen Archives ]

*To*: eigen@xxxxxxxxxxxxxxxxxxx*Subject*: Re: [eigen] Specializing max_coeff_visitor for some number types*From*: Christoph Hertzberg <chtz@xxxxxxxxxxxxxxxxxxxxxxxx>*Date*: Wed, 20 Aug 2014 11:27:20 +0200

On 19.08.2014 15:53, Christoph Hertzberg wrote:

On 17.08.2014 19:34, Marc Glisse wrote:Any comment on this patch? http://listengine.tuxfamily.org/lists.tuxfamily.org/eigen/2014/06/msg00012.htmlHi Marc, sorry I forgot about this thread, so thanks for the reminder. As no further objections arose to your patch, I'll commit it soon.

Christoph

I think adding some documentation somewhere here would be nice: http://eigen.tuxfamily.org/dox-devel/TopicCustomizingEigen.html#CustomScalarType ChristophOn Sun, 22 Jun 2014, Marc Glisse wrote:Hello, here is a new version of the patch. I could have made abs_knowing_score safe against users specializing scalar_score_coeff_op as a derived class of a default scalar_score_coeff_op for a different type, but I don't think it is necessary. Also, I don't really know where to put abs_knowing_score, it is not a unary functor, but moving it far from scalar_score_coeff_op seems strange. And should it appear in the doc? For now I made it so it doesn't. I rely on the compiler eliminating dead code for abs_knowing_score, making the access to the coefficient lazy is more complicated and, I think, unnecessary.

-- ---------------------------------------------- Dipl.-Inf., Dipl.-Math. Christoph Hertzberg Cartesium 0.049 Universität Bremen Enrique-Schmidt-Straße 5 28359 Bremen Tel: +49 (421) 218-64252 ----------------------------------------------

**Follow-Ups**:**Re: [eigen] Specializing max_coeff_visitor for some number types***From:*Marc Glisse

**References**:**Re: [eigen] Specializing max_coeff_visitor for some number types***From:*Marc Glisse

**Re: [eigen] Specializing max_coeff_visitor for some number types***From:*Christoph Hertzberg

**Messages sorted by:**[ date | thread ]- Prev by Date:
**[eigen] unsubscribe** - Next by Date:
**Re: [eigen] Non Negative Least Square solving ?** - Previous by thread:
**Re: [eigen] Specializing max_coeff_visitor for some number types** - Next by thread:
**Re: [eigen] Specializing max_coeff_visitor for some number types**

Mail converted by MHonArc 2.6.19+ | http://listengine.tuxfamily.org/ |