|Re: [eigen] Specializing max_coeff_visitor for some number types|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
Any comment on this patch?
On Sun, 22 Jun 2014, Marc Glisse wrote:
here is a new version of the patch.
I could have made abs_knowing_score safe against users specializing
scalar_score_coeff_op as a derived class of a default scalar_score_coeff_op
for a different type, but I don't think it is necessary. Also, I don't really
know where to put abs_knowing_score, it is not a unary functor, but moving it
far from scalar_score_coeff_op seems strange. And should it appear in the
doc? For now I made it so it doesn't. I rely on the compiler eliminating dead
code for abs_knowing_score, making the access to the coefficient lazy is more
complicated and, I think, unnecessary.