| Re: [eigen] Bugs on bugzilla |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
On 17.06.2014 17:50, Gael Guennebaud wrote:
On Tue, Jun 17, 2014 at 4:45 PM, Jitse Niesen <jitseniesen@xxxxxxxxx> wrote:
I'm not sure it is ideal to close feature requests due to lack of
interest. To me closed means that we are not going to do that, while a lack
of interest means that it is not going to be done anytime soon but that if
somebody else would do it, we would maybe incorporate it. Perhaps an
INACTIVE state would reflect this better?
If someone has interest in a bug, then the bug should be turned as
"CONFIRMED" and it won't be closed arbitrarily.
Yes, and even if it got closed, everybody has the right to re-open.
Perhaps, we can add "INACTIVE" as another form of resolution.
I guess we do need the "ReviewNeeded" status to support bitbucket pull
requests. In that case, I think we should remove the review flag on
bugzilla patches so that we do not have two systems to indicate that a
patch needs review (I do not think that the more specific nature of the
bugzilla system buys a lot).
The patch reviewing system of bitbucket is indeed much better. The downside
is that scatters the discussions but since that's already what's happening,
why not.
What I like more about the bugzilla reviewing system is that it is
possible to make per-line comments (or did I just not find this on
bitbucket?).
OTOH, especially for trivial patches, bitbucket pull-requests are much
easier to approve/merge.
Further downsides of having two mostly independent systems are that
following pull-requests is another thing a person interested in
contributing must set-up (I did never checked how to do that, I merely
started getting notifications since I got write-access).
Also, we can't make pull-requests block or get blocked by other bugs.
This also means, once we have more open pull-requests we have a similar
problem as with open bz-bugs. A workaround would be to make a bz-entry
for every (non-trivial) pull-request.
We should probably update the wiki to reflect the changes to how we are
using bugzilla.
Yes, certainly. Are we sure yet what is the preferred way to submit
patches (depending on the kind of patch)?
Christoph
--
----------------------------------------------
Dipl.-Inf., Dipl.-Math. Christoph Hertzberg
Cartesium 0.049
Universität Bremen
Enrique-Schmidt-Straße 5
28359 Bremen
Tel: +49 (421) 218-64252
----------------------------------------------