| Re: [eigen] Patch to fix build on msvc |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Patch to fix build on msvc
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 29 Dec 2010 14:00:56 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=3YuKy5IzAsQOu8Tz5PBfW+GpRw3vc+/kMez6CvkzqbA=; b=rGJE5yn8f8w+ncfhPqwyS8otJeFIVhVI5o8lJSRDTWAmvloCMuhhAJPY6Ki5bMDeje fof+VqojYyZG8LtxeTUzYgfnqkV5UZm7WB0r2LNizbKpnWwZF7AwYkij874JfIGGuSFv +CPBkDywj3BM5Kj8J55qPJ/zN1OikeXw+qGhg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=aFviey90WfNoU9aa67TPvUlwFIjomEc8e0zRyqYxkbKNQdjbjXVJTocaAfmsaJRcEr kPL78m5IOuOtPyYK8z5UsxjuYVOTFR2cgJcOniqnG/PB9W2geG2Z4vhVpNQr3v/MxVb/ 0BI1QcWi7jSYbIQbjk3/QowXtn2x3e+hrp9s4=
Thanks, pushed, but I changed your identity to use your full name and
email address, see hg log.
2010/12/29 Jose Luis Blanco <joseluisblancoc@xxxxxxxxx>:
> You're right, the <Derived> wasn't really needed.
> I attach the new patch, now in Hg format.
>
> Best,
> JL
>
> On Wed, Dec 29, 2010 at 5:08 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
>> Very weird. Could you please try if it's at least working like this:
>>
>> typename DenseBase::Const...
>>
>> i.e. the <Derived> should really not be needed in this context.
>>
>> Could you please add a comment there explaining the reason for the change.
>>
>> Also, please generate your patch with hg commit and hg export, so it's
>> ready to import and push.
>>
>> Benoit
>