| Re: [eigen] Patch to fix build on msvc |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Patch to fix build on msvc
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Wed, 29 Dec 2010 11:08:14 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=hSwA7SDbt5FmM84NDPqsYhXfzL345yiZedA6swRXEE4=; b=wOxl6heCtfA8UL5u54WwxokbheO9f5TjPL65NNL51KoEkn01Wb2Ek6xsd5wB7aiUb6 N75i+vjq0ssebm0sCkj+wTth0a4hbruipUevMVNlOnQzaxMOwE1yNSM9Q6q9wYmJVyqo l1z1dH3NC/40cNnS3SJpyzuf9jNF2SskjhXEc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=Jmk4E7p0A6KBC027cJ+Sx/Ls2mctOkUam13rlQe1uaLMswBdjuvRvDWmEprHF76ZLt o46JUvwau9bCm/O66GZ447IBurIzuJWuaEtegU632y7hR2xGJvCpo526fIFktutJk4q+ nUAk0VKWEUM0rMEAWWI+4Jx0yLoPqsyizBeZI=
Very weird. Could you please try if it's at least working like this:
typename DenseBase::Const...
i.e. the <Derived> should really not be needed in this context.
Could you please add a comment there explaining the reason for the change.
Also, please generate your patch with hg commit and hg export, so it's
ready to import and push.
Benoit
2010/12/27 Jose Luis Blanco <joseluisblancoc@xxxxxxxxx>:
> I attach a patch to fix the errors msvc complains about with the
> latest hg revision. Don't ask me why, but it needs names to be like
> that...
>
> Best,
> JL
>