| Re: [eigen] Patch to fix build on msvc |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Patch to fix build on msvc
- From: Jose Luis Blanco <joseluisblancoc@xxxxxxxxx>
- Date: Wed, 29 Dec 2010 19:44:59 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=c7lneGMmwr8bDG5Tb9ld8DC8zYLqAUulFV2g2Y/0wxw=; b=FqiHDfBY9SjZ91dibPd72vhRsSGLT7gchvsKzd4H0beIhhXp61+3VlTKKjJyiLkToW GLbInQJ3gL0Qo7nrVm4xJRWUGUDmHgTrC7NgbaTmhT50YjnHwRnuzzOO+8+UVaioDrgh U0iBdFp1v5QQjbJ08XsIldzMrk7JlTZhxBq9A=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=S5bHi4rZ1XTaasQMHswFTgbMBDy5T5n4yd/hNMKluPqNhi185m5BJSNgge3bsKiBPD 8+3/6IlhUubjtcYf/Heov8rWfUe1AigbMezoVxEM3HdjW479vCHn+9QTnpPvs9poPFyG xQk7SX8qGbEuuSK2H1HPZsdBah7n6LL+6E7F0=
You're right, the <Derived> wasn't really needed.
I attach the new patch, now in Hg format.
Best,
JL
On Wed, Dec 29, 2010 at 5:08 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> Very weird. Could you please try if it's at least working like this:
>
> typename DenseBase::Const...
>
> i.e. the <Derived> should really not be needed in this context.
>
> Could you please add a comment there explaining the reason for the change.
>
> Also, please generate your patch with hg commit and hg export, so it's
> ready to import and push.
>
> Benoit
Attachment:
eigen3-hg_rev3607.patch
Description: Binary data