Re: [eigen] Do we need geometry refactoring?

[Benoit Jacob <jacob.benoit.1@xxxxxxxxx>]

2010/8/3 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> On Tue, Aug 3, 2010 at 3:53 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
>
>>> - It is unintuitive that the most generic Transformation is affine
>>
>> Let's focus on this point because it looks crucial to me. The most
>> generic transformation is definitely projective, there's no question
>> about that, the questions discussed here are:
>>  a) what should the default value for Mode be?
>>  b) what should the Transform3f (etc) typedefs stand for?
>>
>> Obviously, a typedef named "Transform3f" has to use the default mode,
>> but at the same time that name "Transform3f" does suggest something
>> generic, whence the confusion in this discussion between "default" and
>> "generic".
>
> Right, you nailed it. So, we agree that Transform3f is likely to
> suggest something generic.
>
>> What do you think about this plan:
>>  - we just remove the Transform3f... typedefs. We just force the user
>> to use the mode-specific typedefs such as Affine3f, Projective3f, etc.
>>  - we don't give Mode any default value.
>>  - in the tutorials, we focus (at least at the start) on Affine
>> transforms, Affine3f etc, so that the intuitive idea that 3D-transform
>> * 3D-vector gives a 3D-vector. Of course we then do explain other
>> kinds of transform.
>
> Sound like a plan. Gael, do you have any opinion?

Hauke: the geo_hyperplane test fails to build at the moment, something
related to Transform and some matrix not having the right size. This
is most probably related to your change, no?

Also: the Hyperplane::transform() methods are still taking a
TransformTraits runtime parameter, which we probably want to get rid
of.

Benoit

>
> - Hauke
>
>
>