| Re: [eigen] Feature suggestion: interior row and column ranges [patch attached] |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Feature suggestion: interior row and column ranges [patch attached]
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Sun, 27 Jun 2010 12:25:31 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=rIZtr/mnXuVf7UphzZhPnVvjDvDluFwh0YBXOvzzWos=; b=G7bopqsfsQcGP5G5hLxe8Yoa9kMDVnnD2lGlbwFvI1UPwRxFPO89jjTRhpu2v1aMql LytjMb3l+K06N9TjiBIkO7waAF6xmIvyNZdypBCDRHXMOBtnLrqirhgXXF8/h4Dxq2k3 vU3mNXH2qL8EZTwTTAMuvqQCEPO/LH4faWbS0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=qG0jeIAGDxcIHVQy1prj62V923uZbv94OQg/uMnMKZksFSizVLjCo5kgnqnYpUBxJN WyKGl4oTQryubPI3HkILaE+W57swIX6fh42FMqXVZg43Fntag0RIWN1R7GsnrhxWU30N cikPgSA8kIPMea43pk4Saq7oKv5Pwbb9GAmSs=
2010/6/27 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> 2010/6/27 Manoj Rajagopalan <rmanoj@xxxxxxxxx>:
>> Do you want me to resend the patch with the new names - middleRows() and
>> middleCols()?
>
> Yes please and also make sure to indent with spaces, not tabs, in DenseBase.h
Also please update test/corners.cpp to test all your new functions.
And yes, that filename becomes not so good anymore, but let's take
care of that later.
Benoit
>
> Benoit
>
>>
>> Thanks,
>> Manoj
>>
>>
>>
>