|Re: [eigen] Feature suggestion: interior row and column ranges [patch attached]|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Feature suggestion: interior row and column ranges [patch attached]
- From: Manoj Rajagopalan <rmanoj@xxxxxxxxx>
- Date: Tue, 29 Jun 2010 12:50:06 -0400
- Organization: EECS Dept., University of Michigan, Ann Arbor, MI, USA
I made the changes and performed a local commit without rollback on the
previous local commit. Now the hg export tip > diff-file stores only the diff
with respect to the last local commit and not with respect to the
file-versions in the hg repo.
How do I fix this problem? I performed one rollback (after making a copy of
the latest file with all desirable changes) and I got back the file with
rowRange() instead of middleRows(). Now I need to replace this with the file
in the repo. "hg revert DenseBase.h" doesn't seem to have any effect.
On Sunday 27 June 2010 12:25:31 pm Benoit Jacob wrote:
> 2010/6/27 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> > 2010/6/27 Manoj Rajagopalan <rmanoj@xxxxxxxxx>:
> >> Do you want me to resend the patch with the new names - middleRows() and
> >> middleCols()?
> > Yes please and also make sure to indent with spaces, not tabs, in
> > DenseBase.h
> Also please update test/corners.cpp to test all your new functions.
> And yes, that filename becomes not so good anymore, but let's take
> care of that later.
> > Benoit
> >> Thanks,
> >> Manoj