| Re: [eigen] Feature suggestion: interior row and column ranges [patch attached] |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Feature suggestion: interior row and column ranges [patch attached]
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Sun, 27 Jun 2010 12:21:37 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=8yA5tCG8Hc/3L8WPUNkQ9+GN2hHT1ih+s/UqD94/1rU=; b=Mixga0RF1O1vv65IkF49tFVMkO9cEDrrNe7QFFwIwDN7twM3lBBuw+emKPgqOIYlBd ih7OrR+WmolXoMbb6vX715967dCA4ScCAM3/aaeu3zOL9MTD11RCkdEswyLB4leRErPF jUfmKgdgssOxOABDZl3xtjfoBbcphFi6F5fAg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=xD8rhsdheIi/yyXtTbSgiHItY6jkkUu4HJ/ErZRyQ2nD0opwGYBn47k3yMfuBEEvh4 eJtoJ83NRUH7aMt8HmlECS9zmw9Nd+HFO0T3ncz9tr/xxe0DhMOiJmtc9vYyddsqjBSH 5zTI+iJsaRKHyhF8iHqfnQamGe4HAymcoD2VI=
2010/6/27 Manoj Rajagopalan <rmanoj@xxxxxxxxx>:
> On Sunday 27 June 2010 09:59:03 am Benoit Jacob wrote:
>> I still prefer middleRows() over all of these...
> <snip>
>> If there is really no good name for this method, let's just not add
>> it. After all, the user can do the same with explicitly constructed
>> Block objects. Adding a method only adds value if it has a good name.
>>
>> Benoit
>
> OK OK I surrender ... middleRows() is fine! :-) LOL! Having such a function
> included would make for readable code so IMHO the name of the function is
> secondary to the purpose it will serve. If the developers think middleRows()
> fits best, then middleRows() it is! :-)
>
> Do you want me to resend the patch with the new names - middleRows() and
> middleCols()?
Yes please and also make sure to indent with spaces, not tabs, in DenseBase..h
Benoit
>
> Thanks,
> Manoj
>
>
>