[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] STL fixes
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Sun, 18 Apr 2010 20:19:43 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type; bh=3dF458XhlJhY0p+weWzgcObQJjnj/nuQDxG7wB3wXhA=; b=wox5xdIWDbWz0k0JcWlEJnv2viU8tmsEM50BNJI1S46+NEHe31caZz6nzwRpFoSgFY 9Ri70HIywHu1XBkwym+itE1hnYPamkdJ2xq/s/qtTtPa5HFmlOPGeUL3F97OXXJVfagj ec4SkaUYKr7nj/tIO0ZSTAGN2qnmJvFjdmauY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=CaiOCKJF7oYLboCS+gqd6lW/zgKrJJWV4SvlOLIbb3xER1WacUHNI8Y/6OebwGtjEf 1FutQRz8C23PBedlNjb5p0F5fdUVhmIoQLqmWL1QbUZENAPw0jKvUY4BM1HrYJ8cC5iD MhYYi8o1DZSw/I8Lag5QvxaHB1afWScD+poGY=
For the first version I submitted a two file version.
That means, at the moment we have
Eigen/StdList
Eigen/StdVector
plus the module Eigen/src/StlSupport.
Regards,
Hauke
On Sun, Apr 18, 2010 at 7:59 PM, Gael Guennebaud
<gael.guennebaud@xxxxxxxxx> wrote:
>
>
> On Sun, Apr 18, 2010 at 4:53 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
> wrote:
>>
>> 2010/4/18 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>> > Hi,
>> >
>> > I started working on applying more STL fixes. In particular adding
>> > std::list support since in many implementations we are striking the
>> > same push_back issue as in std::vector. I am also disabling those
>> > specializations when they are not required.
>> >
>> > For that matter, I created a new sub-folder/module
>> >
>> > src/StlSupport
>> >
>> > which will hold two files (maybe more, depending on whether I can
>> > factor code when writing the StdList header)
>> >
>> > StdList.h
>> > StdVector.h
>> >
>> > I am now wondering whether you are OK with renaming Eigen/StdVector to
>> > Eigen/StlSupport or whether you want to keep StdVector and add StdList
>> > on top of that!?
>>
>> Good question!
>> A single StlSupport include is more convenient, but separate headers
>> allow to do these intrusive changes only on the classes one really
>> needs to tweak.
>>
>> Maybe i'm a bit in favor of your change, because the case where one
>> would want to tweak only vector and not list, is probably very
>> uncommon....
>>
>> Do as you think is right :)
>
> exactly the same feeling here!
>
> gael
>
>
>>
>> Benoit
>>
>> >
>> > Regards,
>> > Hauke
>> >
>> >
>> >
>>
>>
>
>