[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] STL fixes
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Sun, 18 Apr 2010 10:53:26 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:content-type; bh=9eY2n1/gDTlpeeA/EPw7jQ0qCO4g6fIzu7wkiGSbpVQ=; b=cdg5tmY+eeCImH2Wc5rl5o4SsfkFp47dY5gVXQEgCvQEaE9J5z49bGjLwkpHv5CHd7 h9OMS05YYdNICIJeDQDZF2RakEQLIVEBoxRSR1hXvHAAGcyRxajKz0J2YLoyUPKK3Qj8 YlF7pV3Y7YNvkg53dRakXYEXJ2MftQAPRaXGk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=VSEznZlXSJ3nWLO3hOBV4WGOtfrj7TbLI0MryFP1U3wfy2sb9q02SPdWPERXvqbyRY X6x10Nnv6vfdFkviSriXvq6K7JkR2PXIMd/oldu7O/daWjxWGznCYRJzJvNIK3X5y8xE suZC714nPMm5NZxWr3HMLUkIzAU3BaqKfvCs0=
2010/4/18 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> Hi,
>
> I started working on applying more STL fixes. In particular adding
> std::list support since in many implementations we are striking the
> same push_back issue as in std::vector. I am also disabling those
> specializations when they are not required.
>
> For that matter, I created a new sub-folder/module
>
> src/StlSupport
>
> which will hold two files (maybe more, depending on whether I can
> factor code when writing the StdList header)
>
> StdList.h
> StdVector.h
>
> I am now wondering whether you are OK with renaming Eigen/StdVector to
> Eigen/StlSupport or whether you want to keep StdVector and add StdList
> on top of that!?
Good question!
A single StlSupport include is more convenient, but separate headers
allow to do these intrusive changes only on the classes one really
needs to tweak.
Maybe i'm a bit in favor of your change, because the case where one
would want to tweak only vector and not list, is probably very
uncommon....
Do as you think is right :)
Benoit
>
> Regards,
> Hauke
>
>
>