Re: [eigen] again msvc inlining...

[Eamon Nerbonne <eamon.nerbonne@xxxxxxxxx>]

Hmm, that's not the case with the program I'm building - rather, adding more forced inlines makes it faster.

--eamon@xxxxxxxxxxxx - Tel#:+31-6-15142163

On Sun, Mar 14, 2010 at 10:49, Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx> wrote:

I will shortly remove more of those 'forced inlines' and for the
future I urge everybody to stick to simple inlines if not proven that
we really need strong ones. I totally understand that one is being
tempted to force inlining of mere forwarding calls in particular for
all those calls up and down our _expression_ trees -- but we seem to be
underestimating todays compilers.

- Hauke

On Mon, Mar 8, 2010 at 10:59 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> 2010/3/8 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>> Hi,
>>
>> for known reasons, MSVC is oftentimes not inlining
>> DenseBase<Derived>::eval(). Any objections against changing the
>> EIGEN_STRONG_INLINE into a simple inline?
>
> Replacing a EIGEN_STRONG_INLINE by a 'inline' is generally something
> you can do without asking since
>  - you're the MSVC guru
>  - if there were another compiler needing this, the person having
> added this EIGEN_STRONG_INLINE should have added a comment explaining
> the reason for it :)
>
> Benoit
>
>>
>> Regards,
>> Hauke