| Re: [eigen] again msvc inlining... |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] again msvc inlining...
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Sun, 14 Mar 2010 10:49:56 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=urg/wLYA9NexBmRGrBYrStg0TSZ+aE4WktqIpSAKwDA=; b=b/BJE8X7bl0bgHASwsspJ4wT5DU8QbBfyhgoFbIloyP79Oj7/6v9+KWEr7aZ8nNifO KMzMPw3UO+fNa/uh6pNY7ymQ8B00JEuslu8coPT1bqQSbjo+CexICIycwygPw/i5TG2q 2QI4sqazTQqPYBvehCXvsiDCJCDigZD+e7e8c=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=QdHYykhy6e7WZ0t9DclkaDoA/wQHLzL7MUEw4DJdOlFRMECG+CZ2q7kVm4airiBGZC fcbvIwSvxxq3UhML2CTbRt7BjKD7Llu/wW6KmOka1oYkGWiOJQK4T2epKgdaFWyOt4yE 2T2eWmH9Vk1QPhSiRPIsHE2f6Z/LnmIsSnNQw=
I will shortly remove more of those 'forced inlines' and for the
future I urge everybody to stick to simple inlines if not proven that
we really need strong ones. I totally understand that one is being
tempted to force inlining of mere forwarding calls in particular for
all those calls up and down our expression trees -- but we seem to be
underestimating todays compilers.
- Hauke
On Mon, Mar 8, 2010 at 10:59 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> 2010/3/8 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>> Hi,
>>
>> for known reasons, MSVC is oftentimes not inlining
>> DenseBase<Derived>::eval(). Any objections against changing the
>> EIGEN_STRONG_INLINE into a simple inline?
>
> Replacing a EIGEN_STRONG_INLINE by a 'inline' is generally something
> you can do without asking since
> - you're the MSVC guru
> - if there were another compiler needing this, the person having
> added this EIGEN_STRONG_INLINE should have added a comment explaining
> the reason for it :)
>
> Benoit
>
>>
>> Regards,
>> Hauke