| Re: [eigen] std::vector specialization |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] std::vector specialization
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 28 Jan 2010 07:32:24 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=hHWhBMaYqGxcCEjvK7fhL8pAGCdPhQ09cwgn6+VFwI8=; b=OQxNfF18phmYvr01HjjQLKR2cwlyu4avsNb/n+TfCjyrxBF9vjbvF96EpkdaNA4Q8W XkG43cblzgcpaPe7Q8ZfE3hOpl0wqggyU0jPULLO9kkquHP/0OtvuyD9qzGIX1pQsHiX jfVrYXgEqZ10jcP6f7tBDpy6LUUBkMx1FMeu0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=fGXmT/ZoI02Qs72sg/jukdLQHEiS+PGYCWfEU+aECGSQfJMfVhjrgZFuinYYb6MMtb REDjST1kx4W48ZNatnnCkOGZkpWuhiJlbFXdl9upgGmb1riGc3uIjWlai7hbfAu3XVtW pES79vLsBbNGHqhhqHvI42hqEXj3ABnkRTSIc=
2010/1/28 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> In order to silence the warnings we are seeing in the dashboard
> (warning: anonymous variadic macros were introduced in C99) we can add
>
> -Wno-variadic-macros
>
> which works for GCC 4.x and according to this thread
> http://www.gamedev.net/community/forums/topic.asp?topic_id=510702, we
> might add
>
> #pragma GCC system_header
>
> to the StdVector header when GCC 3.x is used.
>
> Does that sound all right to everybody?
In order to do -Wno-variadic-macros for the user, we have to do a
pragma. Then re-enable it with opposite pragma. I'm not opposed to
doing it, it could go into (Disable|Enable)MSVCWarnings.h which could
get renamed to (Disable|Enable)Warnings.h.
Benoit
>
> - Hauke
>
> On Tue, Jan 26, 2010 at 10:26 PM, Gael Guennebaud
> <gael.guennebaud@xxxxxxxxx> wrote:
>> On Tue, Jan 26, 2010 at 7:57 PM, Hauke Heibel
>> <hauke.heibel@xxxxxxxxxxxxxx> wrote:
>>> On Tue, Jan 26, 2010 at 3:16 PM, Thomas Capricelli
>>> <orzel@xxxxxxxxxxxxxxx> wrote:
>>>>
>>>> We can fix this once pushed, do not worry :)
>>>
>>> I just would like hear Gael again. There was some discussion on this
>>> topic in the past, just check here:
>>>
>>> http://listengine.tuxfamily.org/lists.tuxfamily.org/eigen/2009/04/msg00143.html
>>>
>>> It seems as if there was an issue with template arguments. It might be
>>> the case that it's working here because I am using typedefs only. I
>>> have to double check that on another day.
>>
>> the problem was that we wanted to allow partial specializations in
>> order to handle Matrix* in one shot. But here you are requiring full
>> specialization for the value type, so no such problem.
>>
>> gael
>>
>>>
>>> - Hauke
>>>
>>>
>>>
>>
>>
>>
>
>
>