| Re: [eigen] std::vector specialization |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] std::vector specialization
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Tue, 26 Jan 2010 07:15:05 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=lUrtVADm8X4vHstVpHQ6G80NjQaGrNlmanblTT8sGvs=; b=o0PgOz+sehtNQt4/tJmly0Otwth+8CXxu70YjC9y68sMWSGyOkzWBsZUS8aeBfvte3 vwxLamxchfviXF36q9nnlHEuTEDAED3HKOBcdulni4Ca9DIJMxAmCEAI46EA5P4p7kOy G64yM4VJuyBJIeeYC/m8jIRMTApIhtVAdEz4g=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=OBYGmjILuC7C/g9LmiBVfgZAnZbXkl0tVNsnhOM/W7rXmPYDUMj70Yl8xRGAtSfSZS 04NnMeWtnqe2oCeFFIXWZqvaQI/Db22oE1fmEXDK8OjFAhPaEwQj/fXDlxxw2IKTxlIO QRBEmajtr9TaoT2Ny54plthGAEIu/0A8q7BnY=
2010/1/26 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> On Tue, Jan 26, 2010 at 10:34 AM, Thomas Capricelli
> <orzel@xxxxxxxxxxxxxxx> wrote:
>>
>> I just have two thoughts about this (but please note that I dont know much about this topic)
>>
>> 1) I'm surprised that you dont have more problems with variadic macros, i remember it was a porting nightmare.
>> 2) there's no unit test... why ? (is it impossible?). You said you've tested this with three compilers... the code you've used for this is probably easy to turn into unit tests, no ?
>
> I modified the existing test\stdvector.cpp - it's now attached. Just
> forgot to add it to the patch. Of course this is just a temporary unit
> test since it does not test the usage of the manual allocator
> definition anymore. The attached version contains the define as well
> as the unit test.
Yes, so you probably need to add the new unit test as a separate test
alongside the existing one.
Benoit