| Re: [eigen] std::vector specialization |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] std::vector specialization
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Tue, 26 Jan 2010 10:43:56 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=9pb7802AEja3n2szjydPTJRgEgwAbqc+dVBCZqrgaqc=; b=ZOtMXR4Hxe/LpJsm+rYTbW+UAbBL/cW2S2p2DYEWnXv6HcX0Z3ivaYd2HrfUoNNZQn uWjlwRTS4xBP37UrqjShSXoP8hneIgIrnjmrYi3ymaxSiLDgvU4mbuQbaYoz/MMcTNN7 Ej9o31y0K0OxtFDTctkuI481TZDKZZp5+zHjk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=IlayNlGsu4vaDjGyVZHExHO8KgOTJHSeBE7se5xsMQ/bP3Efwc/osIElsGKdjdCEUO 93o5Xb3VjltvxEdPghzaD4x5FhK7dhIc+mL2cTjZl+5Sup+6HaCWrtavPj3fX8XgKdVq kFTV14ic0sZZJCMiS9WMJE5xI6KiZNK4Jcskg=
Oh, and one more drawback... it requires explicit instantiation of
std::vector<T> on ICC and GCC.
But still, one could adapt the documentation such that it advises the
user to go for the manual declarations with aligned_allocator in all
interfaces and emphasize that using the macro is not recommended but
just for the lazy people using new compilers. If that were
acceptable... no idea.
- Hauke
On Tue, Jan 26, 2010 at 10:39 AM, Hauke Heibel
<hauke.heibel@xxxxxxxxxxxxxx> wrote:
> On Tue, Jan 26, 2010 at 10:34 AM, Thomas Capricelli
> <orzel@xxxxxxxxxxxxxxx> wrote:
>>
>> I just have two thoughts about this (but please note that I dont know much about this topic)
>>
>> 1) I'm surprised that you dont have more problems with variadic macros, i remember it was a porting nightmare.
>> 2) there's no unit test... why ? (is it impossible?). You said you've tested this with three compilers... the code you've used for this is probably easy to turn into unit tests, no ?
>
> I modified the existing test\stdvector.cpp - it's now attached. Just
> forgot to add it to the patch. Of course this is just a temporary unit
> test since it does not test the usage of the manual allocator
> definition anymore. The attached version contains the define as well
> as the unit test.
>
> Regards,
> Hauke
>