| Re: [eigen] FindEigen2.cmake |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] FindEigen2.cmake
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Tue, 19 May 2009 21:40:17 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=hSh1UYMmT9UMTxuEKW8Y/+3LVpLufJD9aezCjV9hVb8=; b=NlqCjALgf0ztZayWvkURgQK9TTaxtqnbCp59Qgq7zN5mfCBfxOmzv55EOugJWNRYJL mVfLAidzHghomQd9jpKS9QDQbZb+YEWY5c1exYASpU4IrqepV69g5LW+78elKzQx8WMM AKyHJEwe2GUSEp7mYB+DwE4756zo9uNh8TJXc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=C53QLQsGXaJ0ci54lwPCxqg8SHY/ux/FtVWEHPWyDESeDzJJ1Hj+94O4gsFYaQrGzb R4BOBgb8zYF0lwFs+v/NshX/QN08JM5TeRhHuMOnL5aZUIvfxj/dniHbuXt/ti14cCjE IiLGyuivIFftEd9LmqyLaJr00qLhqQuh89VDE=
thanks for your comments, I'll take care of all of them.
Gael.
On Tue, May 19, 2009 at 9:24 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> 2009/5/19 Gael Guennebaud <gael.guennebaud@xxxxxxxxx>:
>> Hi,
>>
>> the previous post remind me that I recently added in kdeedu an
>> extended FindEigen2.cmake module which allows to test the Eigen
>> version.
>
> Wonderful! I had a look at doing that but didn't arrive to such a good solution.
>
>> It basically parses the file Eigen/src/Core/util/Macro.h
>>
>> http://websvn.kde.org/trunk/KDE/kdeedu/cmake/modules/FindEigen2.cmake?revision=928437&view=markup
>
> That's great because this will go much faster than compiling a program
> with Eigen
>
>>
>> I think it would be cool to submit it to the cmake team to be included
>> in the next cmake release. So if there are some comments before I send
>> it to them.
>
> in your regular expression, i'd feel better if you allowed an
> arbitrary number of spaces and tabs between the "define" and the
> number.
>
>> Also, I know cmake has some mechanism to check the version of package
>> containing some special cmake generated files. I chose not to use it
>> because:
>> 1 - redundancy with the information in Eigen/src/Core/util/Macro.h
>> 2 - would not work with previous eigen release.
>
> and 3 - would only work with cmake-installed Eigen, not with
> just-untarred eigen sources.
>
> For 2 - we already have some redundancy since the version number is
> also a string in CMakeLists.txt. But, using your regex code, maybe
> that can be removed! That would be one thing less to take care of when
> making a release.
>
> Until CMake accepts your module, maybe you can simply host it in...
> our own cmake/ directory? So that people can easily find it.
>
> Cheers,
> Benoit
>
>
>