| Re: [eigen] Code review for .resizeLike() |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Code review for .resizeLike()
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Mon, 2 Feb 2009 11:32:25 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Ndfjjz60wRiAvYWGjzycOKgCLGKL+6dq+1tolwrbS6Y=; b=VyNxJ6kM6WRZLcjRy31UNHapwhhOWVvopZeogVy6m95am6+ax26G717zX1dTuHFmNy 59VRP85jzANIPHuaMKhJjnZXJnfjGhPbIyD6i6jbS3PdtGGHyS9FGlKqoSHl0tizXcUY FFmlAA5yJgh1n96B9voGQM8avKVsVvQKqlHhs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=ioBW7JuzEkTLbHxoFeiG9ZuOhTkttFOKyA4d50R4QP0K/xatdfyTjs2TjreDW5cz+v jJE3y8gz35Sn8MjPDYpH/NGzvmrUwUdyf4MNSCSUicqcIeJsWc5Tsxi7bnqPtSJYRmPd tCW65VSlGf+820fDyTbL7pbkkEzx83cJMvH8Q=
sounds good,
you know, you should really apply for a kde svn account and feel free
to commit such changes:
http://techbase.kde.org/Contribute/Get_a_SVN_Account
for "Who supports this request?" you can put either me or Benoit.
Also I've seen you have an implementation of the Levenberg–Marquardt
algorithm and this is something I would love to see as a Eigen's
module. What do you think ? Compared to your current version I would
put the solver as a template parameter so that one can use LU, SVD, QR
or whatever other solvers, like the sparse ones...
gael.
On Mon, Feb 2, 2009 at 3:45 AM, Keir Mierle <mierle@xxxxxxxxx> wrote:
> http://codereview.appspot.com/12869/show
>
> Please comment on this patch (or apply it). I'll make any necessary changes
> and re-upload.
>
> Thanks,
> Keir
>