Re: [eigen] Re: conversions in geometry module

[ Thread Index | Date Index | More Archives ]


to be honest I guess I just forgot to implement them, your commit sounds perfectly fine to me....


On Sun, Dec 7, 2008 at 7:19 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
OK, I committed.

There was an old commented-out operator= taking rotation. I re-enabled
that. Please tell me if there was any reason it was disabled.


2008/12/6 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> specifically, he tried to do:
> Eigen::Transform3f t = Eigen::Translation3f(1.0f, 2.0f, 0.0f);
> and that failed to compile because gcc wanted to use a conversion
> constructor here.
> Instead with current Eigen he has to do
> Eigen::Transform3f t;
> t = Eigen::Translation3f(1.0f, 2.0f, 0.0f);
> I'd fix it myself but I want to make sure it's not conflicting with
> another design aspect...
> Cheers,
> Benoit
> 2008/12/6 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
>> Hi Gael,
>> today a user on IRC was puzzled because Translation's couldn't be
>> casted to Transform's.
>> Is there any specific reason why the Transform class doesn't have (at
>> least explicit) constructors taking Translation?
>> Same question for Rotation types, etc?
>> Any opinion on whether such constructors should be explicit? (Somehow
>> if have a rough feeling that they should)
>> Cheers,
>> Benoit


Mail converted by MHonArc 2.6.19+